Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RawContactContact.kt extensions may return incorrect result if Contact has been linked/unlinked #176

Closed
vestrel00 opened this issue Jan 25, 2022 · 1 comment
Closed

RawContactContact.kt extensions may return incorrect result if Contact has been linked/unlinked #176

vestrel00 opened this issue Jan 25, 2022 · 1 comment
Assignees
@vestrel00
Labels
bug Something isn't working
Projects
Consumer issues

Comments

@vestrel00
Copy link
Owner

vestrel00 commented Jan 25, 2022 •
edited

As discovered in #140, the Contact ID may "change" due to sync or aggregation.

Problem

The ExistingRawContactEntity.contact function defined in RawContactContact.kt may return the incorrect Contact or null even if the Contact still exist.

Solution

Query the database using the RawContact ID (which will not change) to get the latest Contact ID instead of relying on the Contact ID in memory.
@vestrel00 vestrel00 added the bug Something isn't working label Jan 25, 2022
@vestrel00 vestrel00 self-assigned this Jan 25, 2022
@vestrel00 vestrel00 mentioned this issue Jan 25, 2022
Closed
@vestrel00 vestrel00 added this to In progress in Consumer issues Jan 25, 2022
@vestrel00 vestrel00 moved this from In progress to Done in Consumer issues Jan 25, 2022
@vestrel00
Copy link
Owner Author

This is released in https://github.com/vestrel00/contacts-android/releases/tag/0.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vestrel00 vestrel00

Labels
bug Something isn't working
Projects
Consumer issues
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vestrel00