Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Java interop for EventDate companion functions #215

Closed
vestrel00 opened this issue Jun 10, 2022 · 1 comment
Closed

Add Java interop for EventDate companion functions #215

vestrel00 opened this issue Jun 10, 2022 · 1 comment
Assignees
@vestrel00
Labels
enhancement New feature or request
Projects
General maintenance

Comments

@vestrel00
Copy link
Owner

Problem

While working on #213, I found that the EventDate.from functions are not Java-friendly!

Java usage is currently,

EventDate.Companion.from(1990, 0, 1)

Solution

Annotate the from functions with @JvmStatic.

Java usage can then match Kotlin usage,

EventDate.from(1990, 0, 1)
@vestrel00 vestrel00 added the enhancement New feature or request label Jun 10, 2022
@vestrel00 vestrel00 self-assigned this Jun 10, 2022
@vestrel00 vestrel00 added this to In progress in General maintenance Jun 10, 2022
@vestrel00 vestrel00 moved this from In progress to Done in General maintenance Jun 10, 2022
@vestrel00
Copy link
Owner Author

This is included in release 0.2.1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vestrel00 vestrel00

Labels
enhancement New feature or request
Projects
General maintenance
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vestrel00