Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ContactsContract.Groups.SOURCE_ID #303

Closed
9 tasks done
vestrel00 opened this issue Aug 30, 2023 · 1 comment
Closed
9 tasks done

Add support for ContactsContract.Groups.SOURCE_ID #303

vestrel00 opened this issue Aug 30, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@vestrel00
Copy link
Owner

vestrel00 commented Aug 30, 2023

Problem

Similar to #300, this library currently does not support reading and writing the value of Group's ContactsContract.SyncColumns.SOURCE_ID, which is a critical component to sync adapter operations.

Solution

Add sourceId field to GroupEntity and support CRUD operations for it.

Although this library is focused on supporting application use cases instead of sync adapter use cases, this field is pretty simple to add and may be used by apps for read operations/queries. It's not that out-of-place 🤔

  • Regression check GroupsInsert API (new Groups with null source ID but non-null Account should have a non-null source ID automatically assigned to it post-insert assuming sync settings and network connection are enabled).
  • Check that the source ID is settable using the GroupsInsert API.
  • Regression check GroupsUpdate API (source ID should remain unchanged between updates if the user did not change them).
  • Check that the source ID is modifiable using the GroupsUpdate API.
  • Check GroupsDelete API (delete by matching source ID using WHERE clause).
  • Check that GroupsQuery API (find by matching source ID using WHERE clause).
  • Update all in-code documentation, where necessary.
  • Update docs, where necessary.
  • Update gh-pages branch, if necessary.
@vestrel00 vestrel00 added the enhancement New feature or request label Aug 30, 2023
@vestrel00 vestrel00 self-assigned this Aug 30, 2023
@vestrel00 vestrel00 added this to In progress in Consumer issues Aug 30, 2023
@vestrel00 vestrel00 moved this from In progress to Done in Consumer issues Aug 30, 2023
@vestrel00 vestrel00 changed the title Add support for ContactsContract.Groups.SOURCE_ID Add support for ContactsContract.Groups.SOURCE_ID Sep 11, 2023
@vestrel00
Copy link
Owner Author

🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥
This is now release in 0.3.1!
🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

1 participant