-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: AdiEncoder, AddrLed support #25
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to merge this you can. I won't in case you want to test addrled.
I'm going to merge this for now. Since we more or less just pass to the SDK with LEDs, I don't think there would be anything wrong on our end (bug in the SDK is totally possible though, and I intend to test that at some point). |
Describe the changes this PR makes. Why should it be merged?
Adds initial support for the following ADI devices:
Additionally refactors a few things.
AdiUltrasonic
toAdiRangeFinder
for clarity and renamed ping/echo to input/output to match the physical labeling on the wires.Additional Context