Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flush serial buffer on program exit #26

Merged
merged 9 commits into from
Apr 12, 2024
Merged

Conversation

Gavin-Niederman
Copy link
Member

Describe the changes this PR makes. Why should it be merged?

This PR adds a exit function to vexide-startup which blocks for 3ms to flush the serial buffer and then exits the program with vexSystemExitRequest.

Additional Context

  • I have tested these changes on a VEX V5 brain.

@Gavin-Niederman Gavin-Niederman marked this pull request as ready for review April 11, 2024 06:21
doinkythederp
doinkythederp previously approved these changes Apr 11, 2024
@Gavin-Niederman
Copy link
Member Author

Gavin-Niederman commented Apr 11, 2024

Currently the exit function is in the root of the vexide-core crate. I think it might be worth considering moving it into its own module because it is the only export of its kind. I'm not sure what module we could move it to or, if we make a new one, what it should be named.

Copy link
Member

@Tropix126 Tropix126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gavin-Niederman Gavin-Niederman merged commit 26bea55 into main Apr 12, 2024
6 checks passed
@Gavin-Niederman Gavin-Niederman deleted the fix/program-exit branch April 12, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants