Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't compile without critical_section feature #32

Closed
doinkythederp opened this issue Apr 13, 2024 · 2 comments · Fixed by #34
Closed

Doesn't compile without critical_section feature #32

doinkythederp opened this issue Apr 13, 2024 · 2 comments · Fixed by #34
Labels
bug Something isn't working

Comments

@doinkythederp
Copy link
Member

Bug Description

Disabling the critical_section feature makes the crate not compile.

Code to reproduce

N/A

Expected vs. actual behavior

There shouldn't be any broken features.

Additional information

  • I have tested this issue on the latest development release.
  • Rust version (see rustc --version): rustc 1.78.0-nightly (256b6fb19 2024-02-06)
  • vexide version (see Cargo.toml): 273c7bf
@doinkythederp doinkythederp added the bug Something isn't working label Apr 13, 2024
@Tropix126
Copy link
Member

Tropix126 commented Apr 13, 2024

I think we should just remove the feature and just make this mandatory, since it's a critical part (queue laugh track) of our mutex implementation.

@Gavin-Niederman
Copy link
Member

I think we should just remove the feature and just make this mandatory, since it's a critical part (queue laugh track) of our mutex implementation.

I agree; this was only ever a feature because it wasn't used internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants