Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: vexide-graphics crate and driver implementations #33

Merged
merged 19 commits into from
May 5, 2024

Conversation

Gavin-Niederman
Copy link
Member

Describe the changes this PR makes. Why should it be merged?

This PR adds the vexide-graphics crate with a brain display driver for Slint and embedded-graphics.

Additional Context

  • These changes update the crate's interface (e.g. functions/modules added or changed).
  • I have tested these changes on a VEX V5 brain.

@Gavin-Niederman Gavin-Niederman marked this pull request as ready for review April 14, 2024 03:08
Copy link
Member

@doinkythederp doinkythederp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to have slint/embedded-graphics examples?

@Gavin-Niederman
Copy link
Member Author

Would it be possible to have slint/embedded-graphics examples?

I think that this is more of a task for slint and embedded-graphics docs.

@Gavin-Niederman
Copy link
Member Author

I have added usage docs to the crate docs instead of examples because I think examples would be less useful and harder to do.

@Tropix126 Tropix126 added the graphics Relates to the brain screen (drawing, graphics support...) label Apr 17, 2024
Tropix126
Tropix126 previously approved these changes May 5, 2024
Copy link
Member

@Tropix126 Tropix126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Legendary Graphics To Merge) (*once conflicts are resolved)

@Gavin-Niederman Gavin-Niederman dismissed doinkythederp’s stale review May 5, 2024 20:57

examples that require features have poor support and the examples would provide little to no benefit.

Copy link
Member

@Tropix126 Tropix126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tropix126 Tropix126 merged commit a16fd5a into main May 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graphics Relates to the brain screen (drawing, graphics support...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants