refactor: Screen API #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gavin-Niederman
requested changes
May 3, 2024
Comment on lines
+176
to
+183
| pub fn from_dimensions(origin: impl Into<Point2<i16>>, width: u16, height: u16) -> Self { | ||
| let origin = origin.into(); | ||
| Self { | ||
| x0: start_x, | ||
| y0: start_y + 0x20, | ||
| x1: end_x, | ||
| y1: end_y + 0x20, | ||
| start: origin, | ||
| end: Point2 { | ||
| x: origin.x + (width as i16), | ||
| y: origin.y + (height as i16), | ||
| }, |
There was a problem hiding this comment.
It could be convenient to provide an API for creating a rectangle centered at a point.
There was a problem hiding this comment.
I think that these changes may be an accident.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes this PR makes. Why should it be merged?
linepositioning mode, since that has some inconsistent behavior.mint::Point2, instead adding our ownPoint2struct with an actually practical implementation.geometrymodule.drawpixel is now dead. Instead we blanket-implFillfor all types that can be converted into aPoint2.Additional Context
Closes #44. Needs hardware testing.