fix: implement Send and Sync for smart devices
#53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gavin-Niederman
requested changes
May 4, 2024
| @@ -19,6 +19,11 @@ pub struct DistanceSensor { | |||
| device: V5_DeviceT, | |||
| } | |||
|
|
|||
| // SAFETY: Required because we store a raw pointer to the device handle to avoid it getting from the | |||
| // SDK each device function. Simply sharing a raw pointer across threads is not inherent unsafe. | |||
There was a problem hiding this comment.
I believe that these commends should say "inherently unsafe" instead of "inherent unsafe".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes this PR makes. Why should it be merged?
Smart devices are currently not
SendorSync, which makes them not shareable between async tasks. This is because we store a raw device handleV5_DeviceTfor convenience when interacting with the SDK. Sending raw pointers across threads isn't inherently unsound, and the lack ofSend + Syncon raw pointers exists more as a lint.