refactor: `vexide_async` crate organization #55

Tropix126 · 2024-05-05T00:26:12Z

Describe the changes this PR makes. Why should it be merged?

Adds the task and time modules (mirrored off of tokio's crate structure more or less).
Re-exports Task and FallibleTask from async_task to allow users to store task handles without manually adding async_task as a dependency.
Refactors SleepFuture (now named Sleep) to internally store an Instant. This required some minor changes to the reactor.
Adds sleep_until which should be pretty self explanatory.
Updates docs.

Gavin-Niederman

LGTM for the most part.

packages/vexide-async/src/task.rs

packages/vexide-async/src/time.rs

Gavin-Niederman

LGTM

Tropix126 added 2 commits May 4, 2024 19:23

refactor: vexide_async crate organization

c9779d2

fix: expose block_on to prelude again

7f3618d

Tropix126 requested a review from Gavin-Niederman May 5, 2024 00:35

Tropix126 added the async Relates to the vexide async runtime. label May 5, 2024

Gavin-Niederman requested changes May 5, 2024

View reviewed changes

packages/vexide-async/src/task.rs Outdated Show resolved Hide resolved

packages/vexide-async/src/time.rs Show resolved Hide resolved

docs: update comments for async crate

f4c6abc

Tropix126 requested a review from Gavin-Niederman May 5, 2024 22:08

Gavin-Niederman requested changes May 5, 2024

View reviewed changes

packages/vexide-async/src/time.rs Outdated Show resolved Hide resolved

Tropix126 added 2 commits May 5, 2024 18:55

fix: sleep_until rather than sleep_for

c6a8847

Merge branch 'main' into refactor/async-crate

eb2009f

Gavin-Niederman approved these changes May 6, 2024

View reviewed changes

Gavin-Niederman merged commit 4d0b4fb into main May 6, 2024
8 checks passed

Gavin-Niederman deleted the refactor/async-crate branch May 6, 2024 00:17