Skip to content
This repository has been archived by the owner on Jun 19, 2020. It is now read-only.

Project won't build with latest Visual Studio 2017 because of outdated Lua library #49

Open
GiantCrocodile opened this issue Aug 18, 2018 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@GiantCrocodile
Copy link
Contributor

GiantCrocodile commented Aug 18, 2018

The Lua library (.lua) is outdated. The current Visual Studio 2017 version won't compile the project with this lua library because it has been built with an older version of the C++ compiler. For someone with the same problem:

You have to download the latest lua binary from the official site, copy it to the corresponding paths of the C++ project directory and then adjust the Visual Studio project file to point to the right files and directories.

For the future, we have to find a way to make it better. It's not feasible to update the dependency by hand all time nor is self compiling it a good idea.

Before this issue, we also had issues with C includes. These includes has been replaced by their C++ equivalents. (see commit 92e00df)

Also the project specified Windows SDK version didn't fit.

@vexyl vexyl added bug Something isn't working help wanted Extra attention is needed labels Aug 18, 2018
@vexyl
Copy link
Owner

vexyl commented Sep 6, 2018

Windows build is still broken as of today (9/06/2018). I'll try to get it working as soon as I can.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants