You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 19, 2020. It is now read-only.
I do not think CPE should inherit from Protocol, but they should both inherit from some (pure?) abstract base class. See issue #44. Packet inherits from BufferStream, and I'm not sure if it is a good idea to put it under Protocol as it should be used for all protocols not just classic (which suggests that Protocol is poorly named).
I think there should be a abstract/virtual class which is called Protocol and then you got ClassicProtocol and ClassicProtocolExtended. I don't see a reason for Packet class in its current state - it is in detail implemented and I'm not sure other implementations fit better for other protocols. Maybe there should be a Package class to inherit from (like Protocol class) and you provide a default one (like the currently existing one).
I think CPE should be a class which inherits from Protocol and Packet should be an inner class of Protocol?
The text was updated successfully, but these errors were encountered: