Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of code duplication for escape sequence processing in the lexer #19

Closed
Tracked by #49
alexrp opened this issue Feb 18, 2023 · 0 comments
Closed
Tracked by #49

Get rid of code duplication for escape sequence processing in the lexer #19

alexrp opened this issue Feb 18, 2023 · 0 comments
Labels
area: analysis Issues related to language analyses. type: housekeeping Issues that are classified as cleanup or refactoring work.
Milestone
v1.0

Comments

@alexrp
Copy link
Sponsor Member

alexrp commented Feb 18, 2023

celerity/src/syntax/LanguageLexer.cs

Lines 224 to 227 in bf95975

private ReadOnlyMemory<byte> CreateString(string text)
{
// TODO: Build up the string in ParseStringLiteral to avoid duplication of escape sequence processing logic.

@alexrp alexrp added state: approved Feature requests and housekeeping tasks that have been approved. type: housekeeping Issues that are classified as cleanup or refactoring work. area: analysis Issues related to language analyses. labels Feb 18, 2023
@alexrp alexrp added this to the v1.0 milestone Feb 18, 2023
@alexrp alexrp self-assigned this Feb 18, 2023
@alexrp alexrp modified the milestones: v1.0, v2.0 Feb 22, 2023
@alexrp alexrp mentioned this issue Mar 12, 2023
Closed
1 task
@alexrp alexrp modified the milestones: v2.0, v1.0 Mar 12, 2023
@alexrp alexrp removed the state: approved Feature requests and housekeeping tasks that have been approved. label Mar 15, 2023
@alexrp alexrp closed this as completed in 324b48f Mar 15, 2023
@alexrp alexrp removed their assignment Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: analysis Issues related to language analyses. type: housekeeping Issues that are classified as cleanup or refactoring work.
Milestone
v1.0
Development

No branches or pull requests
1 participant
@alexrp