Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul lint API to be less constraining #51

Closed
Tracked by #40
alexrp opened this issue Mar 7, 2023 · 0 comments
Closed
Tracked by #40

Overhaul lint API to be less constraining #51

alexrp opened this issue Mar 7, 2023 · 0 comments
Labels
area: analysis Issues related to language analyses. type: feature Issues that are classified as feature requests.
Milestone
v1.0

Comments

@alexrp
Copy link
Sponsor Member

alexrp commented Mar 7, 2023 •
edited

Not all lint passes will fit into the current model. Lints should just be passed a SemanticTree rather than being called on different node kinds.

This means that we will have to fundamentally rethink how we suppress lint diagnostics, since we currently update the lint configuration as we descend into the tree.
@alexrp alexrp added state: approved Feature requests and housekeeping tasks that have been approved. type: feature Issues that are classified as feature requests. area: analysis Issues related to language analyses. labels Mar 7, 2023
@alexrp alexrp added this to the v1.0 milestone Mar 7, 2023
@alexrp alexrp self-assigned this Mar 7, 2023
@alexrp alexrp mentioned this issue Mar 7, 2023
Closed
7 tasks
@alexrp alexrp added state: blocked Issues that are blocked on some other issue/work. and removed state: approved Feature requests and housekeeping tasks that have been approved. labels Mar 12, 2023
@alexrp alexrp added state: approved Feature requests and housekeeping tasks that have been approved. and removed state: blocked Issues that are blocked on some other issue/work. state: approved Feature requests and housekeeping tasks that have been approved. labels Mar 23, 2023
@alexrp alexrp closed this as completed in e7e2d57 Mar 23, 2023
@alexrp alexrp removed their assignment Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: analysis Issues related to language analyses. type: feature Issues that are classified as feature requests.
Milestone
v1.0
Development

No branches or pull requests
1 participant
@alexrp