Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freezes in game after repacking DC #26

Closed
justkeepquiet opened this issue May 22, 2022 · 8 comments
Closed

Freezes in game after repacking DC #26

justkeepquiet opened this issue May 22, 2022 · 8 comments
Labels
area: tools Issues related to the command line tools. type: bug Issues that are classified as bug reports.
Milestone

Comments

@justkeepquiet
Copy link

Related to #25
I also confirm this problem.

The problem appears after repacking, even if no changes have been made to the files. There are no errors during unpacking/packing.

@alexrp
Copy link
Sponsor Member

alexrp commented May 22, 2022

Can you please confirm whether this happens only with unpack followed by pack or also with the repack command? That would help narrow down whether it's an issue in the data center code or the XML/XSD layer.

@justkeepquiet
Copy link
Author

justkeepquiet commented May 22, 2022

The repack command not tested yet. I just unpack the DC and pack XMLs without changes.
I use fixed XSDs for 100.02: https://drive.google.com/drive/folders/1U1w4GgEgEoeayX3dmMryIX70ztdisCl9?usp=sharing

@justkeepquiet
Copy link
Author

I checked the repack command now. There are no problems in the game.

@alexrp
Copy link
Sponsor Member

alexrp commented May 22, 2022

Thanks, I'll take a closer look.

@alexrp alexrp self-assigned this May 22, 2022
@alexrp alexrp added this to the v1.0 milestone May 22, 2022
@alexrp alexrp added the type: bug Issues that are classified as bug reports. label May 22, 2022
@alexrp
Copy link
Sponsor Member

alexrp commented May 22, 2022

I can reproduce the issue. Given that a direct disk-to-memory-to-disk repack works fine, my hunch is that we're failing to apply attribute keys when packing from XML/XSD. This would explain why some things in the game are super slow - no keys means many common data center queries slow to a crawl.

@alexrp alexrp added state: confirmed Bugs that have been confirmed. area: tools Issues related to the command line tools. labels May 22, 2022
@alexrp
Copy link
Sponsor Member

alexrp commented May 22, 2022

my hunch is that we're failing to apply attribute keys

This is indeed the problem. Trying to figure out why...

@alexrp alexrp closed this as completed in e2110a7 May 22, 2022
@alexrp
Copy link
Sponsor Member

alexrp commented May 22, 2022

@justkeepquiet Give e2110a7 a try. It fixes the issue on patch 115 for me.

@alexrp alexrp removed the state: confirmed Bugs that have been confirmed. label May 22, 2022
@justkeepquiet
Copy link
Author

That fixed on 100.02 too. Thank you.

@alexrp alexrp removed their assignment Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tools Issues related to the command line tools. type: bug Issues that are classified as bug reports.
Development

No branches or pull requests

2 participants