Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure parity between C/C++ and Zig projects with regards to unwind tables #24

Closed
alexrp opened this issue Jul 7, 2021 · 3 comments
Closed
Labels
area: tasks Issues related to MSBuild tasks. type: bug Issues that are classified as bug reports.

Comments

@alexrp
Copy link
Sponsor Member

alexrp commented Jul 7, 2021

Zig doesn't emit the .eh_frame and .eh_frame_hdr sections by default. However, C/C++ compilers (including zig cc/zig c++) do. We should align the behavior as much as possible by default.

@alexrp alexrp added type: bug Issues that are classified as bug reports. state: confirmed Bugs that have been confirmed. area: tasks Issues related to MSBuild tasks. labels Jul 7, 2021
@alexrp alexrp self-assigned this Jul 7, 2021
@alexrp alexrp added this to the 3.0 milestone Jul 7, 2021
@alexrp
Copy link
Sponsor Member Author

alexrp commented Jul 24, 2021

See: ziglang/zig#9067

@alexrp alexrp modified the milestones: v3.0, v4.0 Apr 7, 2022
@alexrp alexrp modified the milestones: v4.0, v4.1 Aug 4, 2023
@alexrp alexrp modified the milestones: v4.1, v4.2 Jan 2, 2024
@alexrp
Copy link
Sponsor Member Author

alexrp commented Jan 5, 2024

Looks like the upstream situation has improved considerably:

Zig now just does the sensible thing by default, which is to include unwind tables on any target where they're supported and useful for providing backtraces. This goes for Zig code and C/C++ code.

@alexrp
Copy link
Sponsor Member Author

alexrp commented Jan 5, 2024

I don't think we actually need to do anything here after all. We could consider a property to disable unwind tables for size optimization purposes, but that's a separate feature request.

@alexrp alexrp closed this as not planned Won't fix, can't repro, duplicate, stale Jan 5, 2024
@alexrp alexrp removed the state: confirmed Bugs that have been confirmed. label Jan 5, 2024
@alexrp alexrp removed their assignment Jan 27, 2024
@alexrp alexrp removed this from the v4.2 milestone May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tasks Issues related to MSBuild tasks. type: bug Issues that are classified as bug reports.
Development

No branches or pull requests

1 participant