Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider integrating zig fmt into the build #28

Closed
alexrp opened this issue Jul 14, 2021 · 1 comment
Closed

Consider integrating zig fmt into the build #28

alexrp opened this issue Jul 14, 2021 · 1 comment
Labels
area: documentation Issues related to the documentation. area: samples Issues related to sample projects. area: sdk Issues related to the MSBuild SDK. area: tasks Issues related to MSBuild tasks. type: feature Issues that are classified as feature requests.
Milestone

Comments

@alexrp
Copy link
Sponsor Member

alexrp commented Jul 14, 2021

Something like:

  • On Build, run zig fmt --check if EnforceCodeStyleInBuild is set.
  • Add a Format target that actually formats source files (i.e. just zig fmt <sources>).
@alexrp alexrp added this to the v3.0 milestone Jul 14, 2021
@alexrp alexrp self-assigned this Jul 14, 2021
@alexrp alexrp added area: documentation Issues related to the documentation. area: samples Issues related to sample projects. area: sdk Issues related to the MSBuild SDK. area: tasks Issues related to MSBuild tasks. state: deliberation Issues that require considerable deliberation and/or discussion before a resolution can be found. type: feature Issues that are classified as feature requests. labels Jul 14, 2021
@alexrp
Copy link
Sponsor Member Author

alexrp commented Jul 24, 2021

  • A FormatOnBuild property would also be useful.
  • The Format target should always just do zig fmt.
  • If EnforceCodeStyleInBuild is set, run zig fmt --check before building.
  • If FormatOnBuild is set, run zig fmt before building (ignoring EnforceCodeStyleInBuild).

@alexrp alexrp added state: approved Feature requests and housekeeping tasks that have been approved. and removed state: deliberation Issues that require considerable deliberation and/or discussion before a resolution can be found. labels Jul 26, 2021
@alexrp alexrp closed this as completed in 3e94573 Jul 26, 2021
@alexrp alexrp added state: resolved and removed state: approved Feature requests and housekeeping tasks that have been approved. labels Jul 26, 2021
@alexrp alexrp removed their assignment Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation Issues related to the documentation. area: samples Issues related to sample projects. area: sdk Issues related to the MSBuild SDK. area: tasks Issues related to MSBuild tasks. type: feature Issues that are classified as feature requests.
Development

No branches or pull requests

1 participant