Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add epoch selection to EpochsSegmentation #139

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add epoch selection to EpochsSegmentation #139

wants to merge 2 commits into from
+86 −1

Conversation

mscheltienne
Copy link
Collaborator

Closes #138

@mscheltienne mscheltienne marked this pull request as draft December 22, 2023 15:03
mscheltienne
mscheltienne commented Dec 22, 2023
View reviewed changes
pycrostates/segmentation/segmentation.py
Comment on lines +252 to +255
@property
def metadata(self) -> Optional[DataFrame]:
"""Epochs metadata."""
return self._inst.metadata
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: remove and edit docstring above, we should probably not start exposing all methods from an epoch object here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EpochsSegmentation should be indexable to retrieve the segmentation per condition
1 participant
@mscheltienne