types broken for typescript esm support

[philkunz]

Initial checklist

• I read the support docs
• I read the contributing guide
• I agree to follow the code of conduct
• I searched issues and couldn’t find anything (or linked relevant results below)

Affected packages and versions

5.3.2

Link to runnable example

No response

Steps to reproduce

The module identifies itself as type=module, yet the corresponding index.d.ts at https://unpkg.com/browse/vfile@5.3.2/lib/index.d.ts on lines 193, 194, 218 and 226 uses non esm compliant imports.
This causes the TypeScript compiler to fail when using new node12 and nodenext moduleResolution modes.

Expected behavior

should work

Actual behavior

does not work

Runtime

No response

Package manager

No response

OS

No response

Build and bundle tools

No response

[wooorm]

What isn’t ESM about those imports?

Stuff works in all our ESM projects. Feel free to propose a solution that works for everyone

[philkunz]

@wooorm import '..' maps to a directory. There are NO directory imports in esm. Esm ALWAYS requires a file specification with extension. The only exception is through either import maps or node modules (meaing when you import another node module, not a directory in a node module), where in both cases additional mappings (the import map or the package.json file) are needed to tell javascript what explicit file to import.

[wooorm]

It works fine in TS in ESM, as the build here shows. If it doesn’t for you, perhaps you should report to TypeScript that they should generate .d.ts files that work with nodenext moduleResolution?

[philkunz]

@wooorm Have you tried with the new nodenext resolution mode for TypeScript?
Also compare here: https://nodejs.org/api/esm.html
--> Mandatory file extensions

[philkunz]

The problem is: You are using a non esm moduleResolution mode for TypeScript -> 'node', while it should be -> 'nodenext' for esm.

[wooorm]

To reiterate, feel free to propose a solution that works for everyone.