Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No window buttons when title bar is disabled #2

Closed
bllngr opened this issue Oct 13, 2018 · 12 comments
Closed

No window buttons when title bar is disabled #2

bllngr opened this issue Oct 13, 2018 · 12 comments
Assignees
Labels
bug Something isn't working

Comments

@bllngr
Copy link

bllngr commented Oct 13, 2018

I'm using Firefox 62 on Plasma 5.13 with the Breeze theme. In Firefox, I've disabled the title bar via hamburger menu > Customize... > uncheck "Title Bar" in the bottom left.

With this configuration, the Maximize/Minimize/Close buttons are not shown. The close buttons appears on mouse over, the others don't appear at all.

@vfrico
Copy link
Owner

vfrico commented Oct 16, 2018

Ok, I'll take a look as soon as possible.
Thanks for reporting

@vfrico vfrico self-assigned this Oct 16, 2018
@bllngr
Copy link
Author

bllngr commented Nov 11, 2018

Anything new on this issue? I just noticed that it may happen only on Breeze Dark, but it also happens with Breeze light. Strangely enough, the titlebar will be dark with Breeze light as well.

@vfrico
Copy link
Owner

vfrico commented Nov 14, 2018

I've looking for a solution to this issue, but it does not seem to be easy to solve, as Firefox does not provide any API to change the colors of the close, minimize and maximize buttons...

@vfrico vfrico added the bug Something isn't working label Nov 14, 2018
@Mte90
Copy link

Mte90 commented Jan 7, 2019

immagine
Only on hover the button to close is showed and right now seems very uncomfortable.

@vfrico
Copy link
Owner

vfrico commented Jan 7, 2019

immagine
Only on hover the button to close is showed and right now seems very uncomfortable.

I still don't know how to workaround this issue.

@Mte90
Copy link

Mte90 commented Jan 7, 2019

I am wondering if it is a problem of firefox or of KDE.
Just the fact that happen only with an icon for me is firefox.
I will share to the Firefox Addon team this ticket and invite them to join the discussion.

@vfrico
Copy link
Owner

vfrico commented Jan 7, 2019

I think that this issue is just that this theme's background color is exactly the same as the close buttons, and they are only visible when you hover them (because the color of the button itself changes)

@bllngr
Copy link
Author

bllngr commented Feb 24, 2019

I finally found the culprit! The window buttons are rendered by the GTK CSD, which uses the GTK3 theme. On my system, the GTK3 theme was set to Breeze, which by default shows dark buttons on a light background. breeze-duo now changes the background color to the same dark gray, which makes the buttons in fact disappear.

Setting the GTK3 theme to Breeze Dark forces a dark CSD titlebar, and thus light window buttons. This can be done either globally via System Settings > Application Style > GNOME Application Style and selecting the Breeze-Dark GTK3 theme, or only for firefox by starting it with GTK_THEME=Breeze-Dark firefox.

@Mte90
Copy link

Mte90 commented Feb 24, 2019

Yes, you are right @sqrt this fix the problem!

@bllngr
Copy link
Author

bllngr commented Feb 28, 2019

I've filed a feature request for breeze-gtk at https://bugs.kde.org/show_bug.cgi?id=404921. So from my point of view, this issue can be closed, @vfrico. :)

@vfrico
Copy link
Owner

vfrico commented Mar 1, 2019

@sqrt Thank you very much!!

@vfrico vfrico closed this as completed Mar 1, 2019
@teaqu
Copy link
Contributor

teaqu commented Mar 7, 2020

Run this command in the terminal to fix the buttons and retain the light theme for everything else such as inputs, scrollbar, etc.

yes | (mkdir -p ~/.themes && (cp -r /usr/share/themes/Breath/ ~/.themes/Breeze-Firefox || cp -r /usr/share/themes/Breeze/ ~/.themes/Breeze-Firefox) && (cp -r /usr/share/themes/Breath-Dark/assets/title* ~/.themes/Breeze-Firefox/assets || cp -r /usr/share/themes/Breeze-Dark/assets/title* ~/.themes/Breeze-Firefox/assets) && cp -r /usr/share/applications/firefox.desktop ~/.local/share/applications/firefox.desktop && sed -i 's/Exec=/Exec=GTK_THEME=Breeze-Firefox /g' ~/.local/share/applications/firefox.desktop) && echo "alias firefox=\"GTK_THEME=Breeze-Firefox firefox\"" >> ~/.bashrc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants