You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the tools/packer/runner.sh.tpl adds host specific folders to the PATH before calling packer to get access to the brew installed qemu binaries:
# TODO: this is a hacky wat to get the qemu binary in here
# this can also be solved by specifying the qemu binary in the packer template!
export PATH="$PATH:/usr/local/bin"
Instead of relying on host installed tools, make everything hermetic in include qemu into the build system!
First attempt in #92, but was unable to get it to compile on macOS using Bazel (compiling without Bazel in macOS works just fine 🤔).
sha512 / sha256
The rules_packer relies on these being installed (using brew install coreutils. Maybe there's a way we can fetch these dependencies directly from Homebrew (or from somewhere else) so we know these tools are always available. For example by implementing a homebrew rule like tools/homebrew/homebrew.build_defs or using https://github.com/tmc/rules_homebrew.
The text was updated successfully, but these errors were encountered:
mvgijssel
changed the title
Include qemu in build system
Improve hermeticity build system
Apr 17, 2022
Currently the Bazel setup requires a couple of host installed tools:
Let's try to make these tools part of the build so we don't have to install them externally.
Ruby
Rules Ruby https://github.com/bazelruby/rules_ruby supports compiling Ruby, but the problem is that this particular Ruby is not cached in any way into the disk_cache / repository_cache. This means for the CI that every time Ruby is compiled from scratch, greatly increasing the CI execution time.
Qemu
Currently the
tools/packer/runner.sh.tpl
adds host specific folders to the PATH before calling packer to get access to the brew installed qemu binaries:Instead of relying on host installed tools, make everything hermetic in include qemu into the build system!
For example we can download the qemu source code here https://www.qemu.org/download/#source and compile this using Bazel and https://github.com/bazelbuild/rules_foreign_cc.
First attempt in #92, but was unable to get it to compile on macOS using Bazel (compiling without Bazel in macOS works just fine 🤔).
sha512 / sha256
The rules_packer relies on these being installed (using
brew install coreutils
. Maybe there's a way we can fetch these dependencies directly from Homebrew (or from somewhere else) so we know these tools are always available. For example by implementing a homebrew rule liketools/homebrew/homebrew.build_defs
or using https://github.com/tmc/rules_homebrew.The text was updated successfully, but these errors were encountered: