changed title and dialogTitle for selection of theme in settings #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: LakkesW <lukas@wichmann.de.com>
|
Actually the idea was that later i wanted to add other themes, and each theme would have 2 subthemes, light and dark. |
|
Maybe you could add another setting for choosing the theme then. That way there would be one entry for selecting the theme and one for switching between light and dark mode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The settings always show the menu item "Dark Theme", no matter which theme is actually selected. The same applies to the title in the theme selection dialog (see screenshot).
This PR replaces title and dialogTitle with a separate string resource.