Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"pure" before function declaration/definition is flagged as unexpected #92

Closed
andrsmllr opened this issue Aug 12, 2020 · 1 comment · Fixed by #100
Closed

"pure" before function declaration/definition is flagged as unexpected #92

andrsmllr opened this issue Aug 12, 2020 · 1 comment · Fixed by #100

Comments

@andrsmllr
Copy link

andrsmllr commented Aug 12, 2020

With the VHDL LS plugin (0.3.1) of VisualStudioCode (1.47.3) the VHDL keyword pure is flagged as unexpected before the function keyword. A list of expected keywords is shown. The keyword impure is among the ones suggest, which I consider mildly ironic.
The keyword pure is optional but correct in this position (the only position where pure can actually appear at all I guess) and should not be flagged.

pure_function_vhdl-ls

According to the plugin's description "As VHDL LS uses the Rust HDL language server, issues related to syntax and semantic checks should be reported directly to Rust HDL".

@andrsmllr andrsmllr changed the title "pure" not recognized as VHDL keyword "pure" before function declaration/definition is flagged as unexpected Aug 12, 2020
@FFFFFFFXXXXXXX
Copy link

FFFFFFFXXXXXXX commented Aug 12, 2020

Seems like the Keyword "Pure" is missing? https://github.com/kraigher/rust_hdl/blob/master/vhdl_lang/src/syntax/tokens/tokenizer.rs

Not sure if related, but adding pure / impure before a function makes the function have the wrong syntax highlighting.
wrong:
grafik
correct:
grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants