Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support different formats for RFID member card keys #157

Closed
laftho opened this issue Jan 22, 2016 · 2 comments
Closed

Support different formats for RFID member card keys #157

laftho opened this issue Jan 22, 2016 · 2 comments

Comments

@laftho
Copy link
Member

laftho commented Jan 22, 2016

Currently membercard keys are stored simply as string in the following case sensitive format:

04:02:63:ea:0f:0f:0f

While this is fine if scanning from many devices, others provide the value as an int or different hex formats.

We should fix this to accept and parse different hex type formats. ie 0x040263ea0f0f0f

@TyIsI
Copy link
Member

TyIsI commented Feb 22, 2017

Do we want Nomos to handle this or do the conversion on the terminals? Or I guess it's better to do both?

@laftho laftho added the wontfix label Mar 8, 2019
@laftho
Copy link
Member Author

laftho commented Mar 8, 2019

yea on second thought, I agree with you @TyIsI that we should just simply require the format and clients are responsible for the conversion. If this becomes an issue for some readers or something in the future we can re-open this.

Closing this as wont fix.

@laftho laftho closed this as completed Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants