Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct a few typos, mostly in user facing strings #168

Merged
merged 1 commit into from Mar 2, 2023

Conversation

Delapouite
Copy link
Contributor

Hi Vitaly

While skimming through the codebase, looking to discover how hard it would be to implement Socket.io support as you mentioned in #21 (comment), I stumbled upon a few typos.

So here's a quick PR with the ones I found.

Thanks for this great tool.

@vi
Copy link
Owner

vi commented Oct 14, 2022

Note that in my mind Websocat v1 branch is marked as obsolete and it is more interesting for me to advance Websocat v3. But there are more unimplemented things than implemented in v3. Websocat v1 is legacy and Websocat v3 may require a solid week or two of concentrated efforts to get to production (and the more features get added to v1, the more distance v3 would need to go to get on par with v1).


Maybe https://crates.io/crates/rust_socketio can be used to bring some more high-evel socketio support to Websocat.

@vi vi merged commit 60f0660 into vi:master Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants