feat: added binaryFiles option #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devstein
reviewed
Oct 28, 2023
There was a problem hiding this comment.
Awesome work! Thank you for contributing and adding tests.
Can you add a section to the README about using this functionality? I would put it above this section
Comment on lines
+98
to
102
| { | ||
| name: "KRM From Binary File", | ||
| dir: "test/krm/binaryfile", | ||
| }, | ||
| { |
There was a problem hiding this comment.
Thank you! Can you add the legacy one too?
devstein
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into the issue that I cannot encrypt a binary file and import that as file secret. With this patch it is possible.
Generated secrets use data instead of stringdata.
Using the base64 encoded data attributes allow the use of encrypted binary files to be used.
This is a followup PR to #210