Plugin logs in to live version while settings are set to acceptatie or a bogus address

[tevas8]

Version

2.0

Description

The user can change the server address in the options menu and save it. Despite the address being correctly saved to a random address, if the user tries a valid user+pass combination for the live server, the plugin will accept it and log in to the live server regardless of the address set in the options menu.

This happens in both FF and Chrome.

While playing around with the server address setting it to non-existent ones, the bug stopped from occuring and was not possible to reproduce.

When making a clean install of FF and the plugin, the bug is reproduceable.

Actual behaviour

When logging in with a combination of username and password that is valid for the live server, the plugin will log the user in even when the server has been changed to something other than https://partner.voipgrid.nl.

Expected behaviour

It should not be possible to log in to the live server after changing the address in the options menu to anything other than https://partner.voipgrid.nl

Steps to reproduce

1. Make sure you are not logged in the plugin
2. Open the options menu for the plugin ("about:addons" in Firefox, or "chrome://extensions" in Chrome)
3. Set the address to https://ANYTHING.voipgrid.nl and save it
4. Log in using a combination of user+pass that is valid for https://partner.voipgrid.nl
5. Open the options menu and notice how the address has been changed to https://partner.voipgrid.nl
6. Click on Settings and notice how it redirects to https://partner.voipgrid.nl

Attached video

FF login to wrong server.zip

[TomOffringa]

Fixed with ce9eaf3