Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wlroots virtual keyboard protocol #1

Closed
Jaakkonen opened this issue Apr 9, 2021 · 3 comments
Closed

Add wlroots virtual keyboard protocol #1

Jaakkonen opened this issue Apr 9, 2021 · 3 comments

Comments

@Jaakkonen
Copy link

https://github.com/swaywm/wlroots/blob/master/protocol/virtual-keyboard-unstable-v1.xml
Virtual keyboard protocol from wlroots does not show up in wayland.app. Maybe this is caused by it not having the wlr- prefix

@vially
Copy link
Owner

vially commented Apr 9, 2021

Previously all the Wayland protocols were coming from either wayland-protocols or the wlr-protocols repositories.

So as long as the protocols are published to either one of these two repositories it should be relatively easy to pick them up (e.g.: update the submodules and run yarn regenerate-protocols).

However, virtual-keyboard-unstable isn't yet part of those repositories and that's why it was not in the list of supported protocols. It looks like it was actually proposed for inclusion into wayland-protocols but I'm not sure why it wasn't accepted.

In any case, supporting protocols that are not part of those two repositories is a valid use-case so I just went ahead and added support for it (2f02f83): https://wayland.app/protocols/virtual-keyboard-unstable-v1

@vially vially closed this as completed Apr 9, 2021
@letoram
Copy link

letoram commented Apr 25, 2021

If you want one I can send you an invite :-)

The point there is not towards your project specifically (sans the assumed conspiracy, though that was somewhat in jest), it is the more general situation - that there is a substantial mass of definitions that you have to treasure hunt for and the set of "what is Wayland" is a very loosely defined one.

@vially
Copy link
Owner

vially commented Apr 25, 2021

If you want one I can send you an invite :-)

I just managed to open an account and replied on there too (hence deleting my previous comment in here). I did actually consider asking you for an invite though 😄.

there is a substantial mass of definitions that you have to treasure hunt for and the set of "what is Wayland" is a very loosely defined one

I definitely agree and that's why I started this project in the first place. Although I did kind of stop halfway there when maybe I should have spent more time hunting these protocols down, but as you say, that's not always easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants