Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger: avoid formatting for strings without additional args #152

Merged
merged 1 commit into from
Apr 26, 2019

Conversation

denizzzka
Copy link
Contributor

At various software it is found very big amount of logger calls where is only single string variable used as an argument.

But if somewhere is logInfo(someGeneratedMsg); called and someGeneratedMsg contains % escape sequence it will be thrown exception.

PR fixes this issue.

Copy link
Member

@s-ludwig s-ludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a bit worried about the silent acceptance of a possibly bad format string, but since we are just talking about logging, this really looks like just a theoretical concern.

@s-ludwig s-ludwig merged commit d96c5cb into vibe-d:master Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants