Implement vibe.core.process for subprocess handling similar to std.process #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-ludwig
reviewed
Jun 1, 2019
|
Thanks for the review @s-ludwig, it would also be good to merge this: vibe-d/eventcore#110, as it causes some bugs in this code |
s-ludwig
approved these changes
Jun 4, 2019
|
Thanks again! Looks good to merge now. I'll add tag a new alpha tag afterwards (or maybe even beta). |
|
Thanks for merging this! Looking forward to using this in my projects :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to keep most of the features of std.process, if there's anything big I missed let me know.
The tests are simple ports from supervised. They don't have full coverage, but the core should be solid.