Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix InterfaceProxy to work with null values. #228

Merged
merged 1 commit into from
Sep 18, 2020
Merged

Conversation

s-ludwig
Copy link
Member

Previously caused crashes and opCast!bool to return true for null instances.

Previously caused crashes and opCast!bool to return true for null instances.
@wilzbach
Copy link
Member

We should probably replace those flaky AppVeyor tests with GitHub actions.

@s-ludwig
Copy link
Member Author

We should probably replace those flaky AppVeyor tests with GitHub actions.

Yeah, would be nice to unify the CI. I haven't looked into GitHub actions so far, though (maybe I should have done that instead of migrating to appveyor.com).

@wilzbach
Copy link
Member

We should probably replace those flaky AppVeyor tests with GitHub actions.

Yeah, would be nice to unify the CI. I haven't looked into GitHub actions so far, though (maybe I should have done that instead of migrating to appveyor.com).

If you enable GitHub actions for this repo, I can play with it on #229.

@s-ludwig
Copy link
Member Author

Actions are enabled, could it be that the workflows name "test.yml" requires additional configuration before it gets executed?

@wilzbach
Copy link
Member

Hmm, they run here: https://github.com/wilzbach/vibe-core/actions/runs/260953798
I think I need to open the PR from a branch of this repo -> #230

@l-kramer l-kramer merged commit 483725f into master Sep 18, 2020
@s-ludwig s-ludwig deleted the interfaceproxy_null branch September 18, 2020 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants