Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assert failures are not properly logged #2180

Closed
FeepingCreature opened this issue Jul 4, 2018 · 1 comment
Closed

assert failures are not properly logged #2180

FeepingCreature opened this issue Jul 4, 2018 · 1 comment

Comments

@FeepingCreature
Copy link
Contributor

When a vibe.d request handler is terminated with an AssertError, the backtrace is logged but not the message, and it is logged later than the actual problem occurred.

@Geod24
Copy link
Contributor

Geod24 commented Jun 24, 2021

Vibe used to catch assert, but that was deprecated a while ago. In general, after an assert is triggered, the program is in an undefined state, so I don't think Vibe should take any action to handle those. See #666 for the discussion.

Feel free to comment / re-open if I missed anything.

@Geod24 Geod24 closed this as completed Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants