Use a timeout in the call to resolveHost #2466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How do I target vibe-d/vibe-core#220 and vibe-d/eventcore#152? Do I have to wait for a tagged release and update https://github.com/vibe-d/vibe.d/blob/master/core/dub.sdl and.. where is the eventcore dub file? It's a bit confusing how things are laid out, sorry. |
|
Eventcore has already been released. I'll release vibe-core tomorrow hopefully, waiting for a PR to be rebased. |
|
FYI the dependency to eventcore is done via the dependency to |
|
Cool. That was my second guess. :) |
|
Once the issue with the SSL certificate is fixed, you should be able to rebase and it should pick up https://github.com/vibe-d/vibe-core/releases/tag/v1.9.4 |
If a connection timeout was set, then use it in the call to resolveHost() just as it's used in the call to connectTCPWithTimeout().
AndrejMitrovic
force-pushed
the
host-timeout
branch
from
3db1562
to
8f7eda6
Compare
Geod24
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will require eventcore + vibe-core updates.
Requires: