REST: Implement viaBody, viaQuery, viaHeader as parameters UDAs
#2516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good and definitely the way to go, I forgot about this when UDAs were made available for parameters. The only thing I have would be to name this "viaX" instead of "byX", as it captures the bi-directional nature of the annotation and doesn't interfere with range constructors that are named like that. |
Since our minimum supported version is v2.084.0 (and should be v2.085.0), and parameters UDAs are available since v2.082.0, it is high time to simplify user code by moving from the error prone UDAs on functions to UDAs on parameters.
|
Ah, I actually hesitated between |
Geod24
force-pushed
the
wpat-on-parameters
branch
from
a378c0d
to
428fafe
Compare
Geod24
changed the title
byBody, byQuery, byHeader as parameters UDAsviaBody, viaQuery, viaHeader as parameters UDAs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something I've been wanting for a while, should make user code much more friendly.
The names have changed to avoid weird overrides with the
headerParam& co functions, but also to make function prototypes shorter.