Add server setting for max HTTP request header line length. #2755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-ludwig
approved these changes
Nov 23, 2023
|
|
|
It looked like the problem was that createTestHTTPServerRequest didn't setup m_settings in the HTTPServerRequest, so the test used a null pointer when trying to access the new max line length settings (e.g. for form-parsing). I believe I've fixed it (by using a default-constructed HTTPServerSettings). |
s-ludwig
reviewed
Nov 24, 2023
http/vibe/http/server.d
Outdated
| @@ -657,6 +658,9 @@ final class HTTPServerSettings { | |||
| /// the url and all headers. | |||
| ulong maxRequestHeaderSize = 8192; | |||
|
|
|||
| /// Maximum number of bytes in a single line in the request header. | |||
| ulong maxRequestHeaderLineSize = 4096; | |||
There was a problem hiding this comment.
This should be size_t in order to be able to be passed to parseFormData on 32-bit builds. maxRequestHeaderSize should probably also be a size_t, since it needs to fully fit into memory, too, but that's a different issue.
Minor note: the indentation here uses spaces instead of tabs.
s-ludwig
approved these changes
Nov 27, 2023
s-ludwig
force-pushed
the
http-max-line
branch
from
fba5fa1
to
50b5163
Compare
Instead of using a hard-coded length of 4096 for the maximum size of lines in the HTTP headers (including the status line), make this configurable in HTTPServerSettings.
s-ludwig
force-pushed
the
http-max-line
branch
from
50b5163
to
27be17f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a hard-coded length of 4096 for the maximum size of lines in the HTTP headers (including the status line), make this configurable in HTTPServerSettings.