Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL Warnings #1

Closed
simeonmalchev opened this issue Mar 29, 2015 · 2 comments
Closed

SQL Warnings #1

simeonmalchev opened this issue Mar 29, 2015 · 2 comments
Assignees
Labels
Milestone

Comments

@simeonmalchev
Copy link
Member

Originally pointed out here:

https://github.com/brettwooldridge/HikariCP/wiki/Pool-Analysis#sql-warnings-2

A connection pool should clear SQL warnings via Connection.clearWarnings() either when the Connection is returned to the pool or before it is taken from the pool. Vibur does not do this.

Further comments:

Determine whether calling Connection.clearWarnings() is necessary, as well as whether it has to happen always or to be configurable.

@simeonmalchev simeonmalchev self-assigned this Mar 29, 2015
@simeonmalchev
Copy link
Member Author

Connection.clearWarnings() will be called or not on every connection upon its return to the pool based on an appropriate configuration option. Current thinking is that by default this configuration option will be turned off, as for example Hibernate is always clearing the connection warnings (if any) after using a connection taken from a pool.

@simeonmalchev simeonmalchev added this to the 3.0 milestone May 20, 2015
@simeonmalchev
Copy link
Member Author

Fixed on Master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant