Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider optimising AbstractInvocationHandler::invoke #9

Closed
rbalamohan opened this issue Apr 27, 2018 · 7 comments
Closed

Consider optimising AbstractInvocationHandler::invoke #9

rbalamohan opened this issue Apr 27, 2018 · 7 comments
Assignees

Comments

@rbalamohan
Copy link
Contributor

On large deployments, due to very high number of executions, AbstractInvocationHandler::invoke shows up a hotspot. Snapshot of the profiler output is given below. Issue is due to the number of times, the if condition is evaluated, causing misses.

snapshot

@simeonmalchev
Copy link
Member

Hi Rajesh, thanks for submitting this PR. Did you actually manage to run some perf / benchmark tests that showed improvement when the calls to getXYZ methods are shortcut?

@simeonmalchev
Copy link
Member

Thanks @rbalamohan, I just merged the PR. How urgent is to you to get out a build with this PR, I was planning to implement some other changes and push out a build after 2-3 weeks, is this late for you?

@rbalamohan
Copy link
Contributor Author

Thanks a lot @simeonmalchev.
If we support minor incremental release, it would be great to have a release before that. We can deploy on production asap. :)

Otherwise, we can wait for the regular release cycle.

@rbalamohan
Copy link
Contributor Author

Hi @simeonmalchev , Is there any possibility of having an early minor release?

@simeonmalchev
Copy link
Member

@rbalamohan, yes, I'll push it over the weekend. I'll let you know once it is done..

@rbalamohan
Copy link
Contributor Author

Thanks a lot @simeonmalchev

@simeonmalchev
Copy link
Member

Fixed / PR merged in release 22.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants