-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider optimising AbstractInvocationHandler::invoke #9
Comments
Hi Rajesh, thanks for submitting this PR. Did you actually manage to run some perf / benchmark tests that showed improvement when the calls to getXYZ methods are shortcut? |
Thanks @rbalamohan, I just merged the PR. How urgent is to you to get out a build with this PR, I was planning to implement some other changes and push out a build after 2-3 weeks, is this late for you? |
Thanks a lot @simeonmalchev. Otherwise, we can wait for the regular release cycle. |
Hi @simeonmalchev , Is there any possibility of having an early minor release? |
@rbalamohan, yes, I'll push it over the weekend. I'll let you know once it is done.. |
Thanks a lot @simeonmalchev |
Fixed / PR merged in release 22.2. |
On large deployments, due to very high number of executions, AbstractInvocationHandler::invoke shows up a hotspot. Snapshot of the profiler output is given below. Issue is due to the number of times, the if condition is evaluated, causing misses.
The text was updated successfully, but these errors were encountered: