Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

Updating Swift to 2.0 #46

Closed
vicc opened this issue Sep 21, 2015 · 8 comments
Closed

Updating Swift to 2.0 #46

vicc opened this issue Sep 21, 2015 · 8 comments

Comments

@vicc
Copy link
Owner

vicc commented Sep 21, 2015

Hi @bre7!

Just updated Chameleon to 2.0. There might be some conflicts with Swift Macros though since several have been deprecated. It would be awesome if you can check it out real quick. Also if you have time, could you add some Swift examples for the new features in the documentation! Thanks!!! 😃

@bre7
Copy link
Collaborator

bre7 commented Sep 21, 2015

I was just reading the README :D Awesome update 👍

Don't bother merging the PR yet, I'll add the swift stuff in there and mention you when it's done ?

@vicc
Copy link
Owner Author

vicc commented Sep 21, 2015

Thank you! Aww man I merged it right before lol yeah just let me know!

@bre7
Copy link
Collaborator

bre7 commented Sep 21, 2015

Hehe, no worries.

One thing, related to Objc...Do you prefer the non-generics version ? For instance, in NSArray+Chameleon.h it would be better to use NSArray<UIColor *> instead of NSArray

@vicc
Copy link
Owner Author

vicc commented Sep 21, 2015

Is that now possible in ObjC? If so, specifying types would be better!

@vicc
Copy link
Owner Author

vicc commented Sep 21, 2015

BTW Should I go ahead and merge the PR? Let me know when you're good. Also, it'll require a cocoa pods update as well right?

@bre7
Copy link
Collaborator

bre7 commented Sep 21, 2015

Yes and yes....I'll upgrade the remaining stuff in the readme this week probably. New in Obj-C

@vicc
Copy link
Owner Author

vicc commented Sep 21, 2015

Thanks bre! Appreciate all the work you put into this! Also the swift shorthand file might not work correctly. Not really sure though.

@vicc vicc added the Planned label Sep 21, 2015
@bre7
Copy link
Collaborator

bre7 commented Sep 23, 2015

Almost done (Only the shorthand methods for now, Swift only version is in the works but it will take a while)

Update: Close this issue for now.

@vicc vicc closed this as completed Sep 27, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants