Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-specific extractor classes that inherit from a base extractor class #69

Closed
LukasMut opened this issue Aug 31, 2022 · 1 comment · Fixed by #91
Closed

source-specific extractor classes that inherit from a base extractor class #69

LukasMut opened this issue Aug 31, 2022 · 1 comment · Fixed by #91
Assignees
Labels
enhancement New feature or request

Comments

@LukasMut
Copy link
Collaborator

LukasMut commented Aug 31, 2022

  • now, one can only use DEFAULT weights for torchvision which is limited behavior (our goal is flexible behavior)
  • we need to make feature extraction more flexible for a source by inheritance from a base extractor class and a backend-specific extractor class (TensorFlowMixin and PyTorchMixin); something along the following lines does the trick
@dataclass(repr=True)
class TimmExtractor(BaseExtractor, PyTorchMixin):

    def __init__(self, config: object) -> None:
        super(TimmExtractor, self).__init__()
        raise NotImplementedError
@LukasMut LukasMut added the enhancement New feature or request label Aug 31, 2022
@LukasMut
Copy link
Collaborator Author

LukasMut commented Sep 9, 2022

  • Write a function that takes in the source (e.g., torchvision, timm) and a source-specific config object (see issue Source-specific config classes #87 ) and returns the respective extractor object (not the class itself)

@LukasMut LukasMut changed the title extractor class for each source with inheritance from a base extractor class source-specific extractor classes that inherit from a base extractor class Oct 9, 2022
@andropar andropar mentioned this issue Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants