Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double themes on catalog.html #617

Open
frozenpandaman opened this issue Aug 8, 2023 · 4 comments
Open

Double themes on catalog.html #617

frozenpandaman opened this issue Aug 8, 2023 · 4 comments

Comments

@frozenpandaman
Copy link

frozenpandaman commented Aug 8, 2023

vichan 5.1.4

Displays at the bottom of the page after the footer:
image

It looks like <div class="styles"> is getting rendered twice.

Normal pages (index, threads) look fine and only have the two.

@4chess
Copy link

4chess commented Aug 9, 2023

That bug has been there forever. Circlepuller fixed it about 2 years ago on his fork when i mentioned it, you might be able to grab a quick fix from there. for a working demo of it his site is https://awsumchan.org/aw/catalog.html and you can see its fixed. his git username is circlepuller, the code he used to fix it should be there. of note and a fyi, he is keeping most changes out of github i notice... so any new changes may or may not be on the git page. Im pretty sure the catalog links showing up twice fix is on his git page tho.

@perdedora
Copy link
Member

perdedora commented Aug 11, 2023

It's no mistery: https://github.com/vichan-devel/vichan/blob/master/templates/themes/catalog/catalog.html#L79
I don't support removing because if you dont have the script options menu, its useful.

We could check if the script options menu are in the array and if it does: don't show inside the catalog

@4chess
Copy link

4chess commented Aug 13, 2023

The PHP foundation will vote on this controversial issue and let us know how to proceed.

@4chess
Copy link

4chess commented Sep 28, 2023

Okay what's up with this? I put <script type="text/javascript">ready();</script> In the global blotter and it makes 2 css drop down menus for the style changer. Is it cuz jquery is loaded in config.php then again in my instance-config.php?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants