Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pretty-bytes dependency shouldn't be bundled #5

Closed
jaydenseric opened this issue Jan 20, 2023 · 0 comments
Closed

pretty-bytes dependency shouldn't be bundled #5

jaydenseric opened this issue Jan 20, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@jaydenseric
Copy link

Describe the bug

This package has a pretty-bytes dependency, but it's incorrectly bundled into the published files of this module. This is an anti-pattern for a bunch of reasons, but the main one is that if the same dependency is used anywhere else in your app the code is duplicated in an app bundle or for the runtime to process, instead of being a shared dependency.

To Reproduce

Look at the published module and notice the pretty-bytes isn't imported, but it's source code has been included directly in the module:

https://unpkg.com/browse/mui-file-input@1.1.3/dist/mui-file-input.es.js

Expected behavior

Dependencies of published packages should be imported and never bundled.

Screenshots

N/A.

Desktop (please complete the following information):

N/A.

Smartphone (please complete the following information):

N/A.

Additional context

N/A.

@viclafouch viclafouch added the good first issue Good for newcomers label Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants