Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lastest changelogs missing in Fastlane #180

Closed
IzzySoft opened this issue Apr 17, 2024 · 6 comments
Closed

Lastest changelogs missing in Fastlane #180

IzzySoft opened this issue Apr 17, 2024 · 6 comments

Comments

@IzzySoft
Copy link

Nothing urgent but I thought you're probably not aware of it: your Fastlane structures lack the latest entries. You might wish to add the corresponding file always before tagging the corresponding release (F-Droid picks up fastlane from the tag).

Speaking of which: as the badge pointing to my repo is still present in your Readme, I assume you want me to keep your app in my repo though it's now available at F-Droid?

@AhsanSarwar45
Copy link
Collaborator

Nothing urgent but I thought you're probably not aware of it: your Fastlane structures lack the latest entries. You might wish to add the corresponding file always before tagging the corresponding release (F-Droid picks up fastlane from the tag).

Thanks for the heads up, didn't knew it picked it from the tag. Will add changelog for next release.

Speaking of which: as the badge pointing to my repo is still present in your Readme, I assume you want me to keep your app in my repo though it's now available at F-Droid?

Yes, I would like to keep it in your repo since it apparently gets updated more quickly compared to fdroid. And thanks for the work you do for open source apps :).

@IzzySoft
Copy link
Author

Will add changelog for next release.

Wonderful, thanks!

Yes, I would like to keep it in your repo

So we'll keep it there:

image

(that box is only visible in my repo browser, though).

thanks for the work you do for open source apps

😍 Thanks for giving me motivation!

@AhsanSarwar45
Copy link
Collaborator

Added changelog with the v0.4.1 tag. Let me know if f-droid picks it up now.

@IzzySoft
Copy link
Author

Looking at HEAD I wonder which one that might be. v0.4.0 has versionCode: 162, so I'd expect a changelog with a name that's definitely higher than 103.txt there.

Looking at pubspec.yaml I see

version: 0.4.0+16

My repo updater pulls the arm64 variant; so obviously the final per-ABI versionCode is calculated as versionCode * 10 + ABI, having arm64 as ABI=2. If that's the case, there should be some 17.txt for the next release (covering the "base version code" mentioned in pubspec.yaml for 0.4.1) – or 17x.txt if you have separate ones for each ABI?

To solve the confusion: my updater looks at the master branch's HEAD. Your tags point to specific release branches – which should work fine for F-Droid (and indeed v0.4.1 has the dedicated 17x.txt changelogs). Will you merge that to your master branch, so my updater would find and pull them as well? Ideally before 5 pm UTC so they are there when the updater runs.

@AhsanSarwar45
Copy link
Collaborator

Yes, I hadn't merged the tags into master, but did that now.

@IzzySoft
Copy link
Author

Thanks – showed up here so it was in time 😃 Should ideally be merged at the time the APK shows up at releases, so it is not missed by my updater.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants