Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to compile with clang11 #282

Closed
SpaceIm opened this issue Oct 24, 2022 · 5 comments
Closed

Fails to compile with clang11 #282

SpaceIm opened this issue Oct 24, 2022 · 5 comments

Comments

@SpaceIm
Copy link

SpaceIm commented Oct 24, 2022

README claims that clang11 is supported, but when I try the basic example with clang11 on Linux, compilation fails:

In file included from /home/conan/w/prod/BuildSingleReference/conan-center-index/recipes/reactiveplusplus/all/test_package/test_package.cpp:1:
In file included from /home/conan/w/prod/BuildSingleReference/.conan/data/reactiveplusplus/0.1.2/_/_/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9/include/rpp/rpp.hpp:13:
In file included from /home/conan/w/prod/BuildSingleReference/.conan/data/reactiveplusplus/0.1.2/_/_/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9/include/rpp/observables.hpp:19:
In file included from /home/conan/w/prod/BuildSingleReference/.conan/data/reactiveplusplus/0.1.2/_/_/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9/include/rpp/observables/specific_observable.hpp:14:
In file included from /home/conan/w/prod/BuildSingleReference/.conan/data/reactiveplusplus/0.1.2/_/_/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9/include/rpp/observables/fwd.hpp:13:
In file included from /home/conan/w/prod/BuildSingleReference/.conan/data/reactiveplusplus/0.1.2/_/_/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9/include/rpp/subscribers/fwd.hpp:13:
In file included from /home/conan/w/prod/BuildSingleReference/.conan/data/reactiveplusplus/0.1.2/_/_/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9/include/rpp/observers/constraints.hpp:13:
In file included from /home/conan/w/prod/BuildSingleReference/.conan/data/reactiveplusplus/0.1.2/_/_/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9/include/rpp/observers/fwd.hpp:13:
/home/conan/w/prod/BuildSingleReference/.conan/data/reactiveplusplus/0.1.2/_/_/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9/include/rpp/utils/constraints.hpp:13:10: fatal error: 'concepts' file not found
#include <concepts>

Could you provide exact minimum supported versions of major compilers please (gcc, clang, msvc, apple-clang, though I guess apple-clang is not supported at all since it fails to compile even with latest version apple-clang 14 due to lack of std::ranges support)?

@victimsnino
Copy link
Owner

I will double check it later and update readme with specific versions of compilers, but CI works fine with clang-11
https://github.com/victimsnino/ReactivePlusPlus/actions/runs/3284620515/jobs/5410805522

-- The CXX compiler identification is Clang 11.0.0

@victimsnino
Copy link
Owner

Double-checked: clang-11 is possible to build RPP without any issues

@SpaceIm
Copy link
Author

SpaceIm commented Oct 25, 2022

Do you link to libstdc++ or libc++?

@victimsnino
Copy link
Owner

victimsnino commented Oct 25, 2022

manually - not. Just doing

export CC=clang
export CXX=clang++
cmake -B build -DRPP_BUILD_TESTS=1
cmake --build build --parallel 12

@victimsnino
Copy link
Owner

Closing due to inactivity and no way to reproduce it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants