Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS "color"-properties are not applying #52

Closed
dasois opened this issue Aug 27, 2014 · 7 comments
Closed

CSS "color"-properties are not applying #52

dasois opened this issue Aug 27, 2014 · 7 comments
Labels

Comments

@dasois
Copy link
Contributor

dasois commented Aug 27, 2014

Trying to set the CSS-property "color" in order to change the color of the progressBar does not get applied.

@dasois dasois added the bug label Aug 27, 2014
@dasois dasois self-assigned this Aug 27, 2014
@dasois
Copy link
Contributor Author

dasois commented Aug 27, 2014

this will fix #28 and #33

@gngeorgiev
Copy link
Contributor

Are you referring to setting it with inline style(probably using the color method) or with external style?

@dasois
Copy link
Contributor Author

dasois commented Sep 2, 2014

Im talking about changing the color property in the external css file.

@gngeorgiev
Copy link
Contributor

Well since the colors are applied using inline styles, css ones will not work. It should be considered to use only one of both. I would go for inline styles only, this will also allow to implement multiple progressbars in future as per #37. I cannot agree with #33 since it conflicts with the other two.

That's just how I see it

@dasois
Copy link
Contributor Author

dasois commented Sep 2, 2014

I have thought about that for a while. I think another solution, which is maybe serving both purposes, would be to define a mandatory css-suffix attribute on the directive, which you'll have to apply to your css-class in order to get the styling.
What do you think about that?

@gngeorgiev
Copy link
Contributor

Okay, here's an idea I just got out of the blue, it's just an idea, but we can use ShadowDom - https://github.com/Polymer/ShadowDOM. Every progress bar will have its own shadow dom, where the styles will use the same classes/ids (will be kept in a <style> tag) and whenever a value changes the shadowdom will be recompiled. Not sure whether this will work or not, but can be worth the try. Instead of including the stylesheet the user will include shadowdom.

@cetra3
Copy link
Collaborator

cetra3 commented Feb 15, 2016

Closing this as a duplicate of #33

@cetra3 cetra3 closed this as completed Feb 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants