Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some demo controls not working #73

Closed
dciccale opened this issue Jul 30, 2015 · 2 comments
Closed

some demo controls not working #73

dciccale opened this issue Jul 30, 2015 · 2 comments

Comments

@dciccale
Copy link

increment, change height and change color are throwing errors in the console and not working.

when clicking on increment

TypeError: ngProgress.status is not a function
    at Object.$scope.count (http://victorbjelkholm.github.io/ngProgress/:369:47)
    at https://ajax.googleapis.com/ajax/libs/angularjs/1.0.1/angular.js:6129:19
    at https://ajax.googleapis.com/ajax/libs/angularjs/1.0.1/angular.js:12496:13
    at Object.Scope.$eval (https://ajax.googleapis.com/ajax/libs/angularjs/1.0.1/angular.js:7770:28)
    at Object.Scope.$apply (https://ajax.googleapis.com/ajax/libs/angularjs/1.0.1/angular.js:7850:23)
    at HTMLAnchorElement.<anonymous> (https://ajax.googleapis.com/ajax/libs/angularjs/1.0.1/angular.js:12495:17)
    at https://ajax.googleapis.com/ajax/libs/angularjs/1.0.1/angular.js:1930:10
    at Array.forEach (native)
    at forEach (https://ajax.googleapis.com/ajax/libs/angularjs/1.0.1/angular.js:110:11)
    at HTMLAnchorElement.eventHandler (https://ajax.googleapis.com/ajax/libs/angularjs/1.0.1/angular.js:1929:5)
$scope.count = function($event) {
  $event.preventDefault();
  $scope.progressbar.set(ngProgress.status() + 9); // .status() is not a function
}

when clicking on change height

TypeError: Cannot read property 'preventDefault' of undefined
    at Object.$scope.new_height (http://victorbjelkholm.github.io/ngProgress/:378:19)
    at https://ajax.googleapis.com/ajax/libs/angularjs/1.0.1/angular.js:6129:19
    at https://ajax.googleapis.com/ajax/libs/angularjs/1.0.1/angular.js:12496:13
    at Object.Scope.$eval (https://ajax.googleapis.com/ajax/libs/angularjs/1.0.1/angular.js:7770:28)
    at Object.Scope.$apply (https://ajax.googleapis.com/ajax/libs/angularjs/1.0.1/angular.js:7850:23)
    at HTMLAnchorElement.<anonymous> (https://ajax.googleapis.com/ajax/libs/angularjs/1.0.1/angular.js:12495:17)
    at https://ajax.googleapis.com/ajax/libs/angularjs/1.0.1/angular.js:1930:10
    at Array.forEach (native)
    at forEach (https://ajax.googleapis.com/ajax/libs/angularjs/1.0.1/angular.js:110:11)
    at HTMLAnchorElement.eventHandler (https://ajax.googleapis.com/ajax/libs/angularjs/1.0.1/angular.js:1929:5)
$scope.new_height = function(new_height, $event) {
  $event.preventDefault(); // $event is not defined
  $scope.progressbar.height(new_height);
}

when clicking on change color

TypeError: Cannot read property 'preventDefault' of undefined
    at Object.$scope.new_color (http://victorbjelkholm.github.io/ngProgress/:373:19)
    at https://ajax.googleapis.com/ajax/libs/angularjs/1.0.1/angular.js:6129:19
    at https://ajax.googleapis.com/ajax/libs/angularjs/1.0.1/angular.js:12496:13
    at Object.Scope.$eval (https://ajax.googleapis.com/ajax/libs/angularjs/1.0.1/angular.js:7770:28)
    at Object.Scope.$apply (https://ajax.googleapis.com/ajax/libs/angularjs/1.0.1/angular.js:7850:23)
    at HTMLAnchorElement.<anonymous> (https://ajax.googleapis.com/ajax/libs/angularjs/1.0.1/angular.js:12495:17)
    at https://ajax.googleapis.com/ajax/libs/angularjs/1.0.1/angular.js:1930:10
    at Array.forEach (native)
    at forEach (https://ajax.googleapis.com/ajax/libs/angularjs/1.0.1/angular.js:110:11)
    at HTMLAnchorElement.eventHandler (https://ajax.googleapis.com/ajax/libs/angularjs/1.0.1/angular.js:1929:5)
$scope.new_color = function(color, $event) {
  $event.preventDefault(); // $event is not defined
  $scope.progressbar.color(color);
}

i could take a deeper look later

@victorb
Copy link
Owner

victorb commented Jul 30, 2015

Hm, seems like some of the interface of the library have changed while the website doesn't reflect this. Thanks for checking it out, I'll take a look later today at it.

Again, thanks for reporting it!

@victorb
Copy link
Owner

victorb commented Aug 2, 2015

Fixed in 99055a3, cd178d5 and 1ebcd66

Thanks again for reporting!

@victorb victorb closed this as completed Aug 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants