Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow strings as skill levels #2

Open
VictorBargains opened this issue Sep 7, 2016 · 0 comments
Open

Allow strings as skill levels #2

VictorBargains opened this issue Sep 7, 2016 · 0 comments

Comments

@VictorBargains
Copy link
Owner

Currently, the description property of a wp_resume_skill term is used to store a numeric value which is then passed as a width to the span.skill-level with role="progressbar" set.

It should be possible to use a short string as this value, such as "Beginner", "Intermediate", etc. If the description has length but is not a number, it should be given width of 100% and that text should be displayed inside.

The WP_Resume::skill_box() function should be updated so that spaces get replaced by dashes when constructing the class name "skill-level-<?php echo $desc; ?>"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant