Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renderer per clock + fix to decorator and context manager + refacto #14

Merged
merged 21 commits into from Nov 18, 2021

Conversation

victorbenichoux
Copy link
Owner

@victorbenichoux victorbenichoux commented Nov 18, 2021

This PR is relatively large, and achieves the following:

  • Add the capability to have different formatting strings for different clocks, which adresses the requests in Suppress line numbers in tock() #12 as well as feature request: easier control on renderer #4
  • Simplifies the format string, with a general name field that works in decorators/context managers as one would expect
  • Refactor by splitting ticktock.timer into ticktock.clocks with clocks, ticktock.collection with collection, ticktock.timers for decorator/contextmanager interfaces
  • Refactor by removing largely unused Clock and tick parameters (e.g. tick_time_ns)
  • Make clock identity consistent by never disambiguating clocks on their names
  • Better tests of context manager and function decorator functionality
  • numerous improvements to the documentation

@victorbenichoux victorbenichoux merged commit 319f653 into main Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant