Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Physac functions conflict with Visual Studio WINAPI function names #49

Closed
ghost opened this issue Dec 31, 2020 · 2 comments
Closed

Physac functions conflict with Visual Studio WINAPI function names #49

ghost opened this issue Dec 31, 2020 · 2 comments

Comments

@ghost
Copy link

ghost commented Dec 31, 2020

OK, This issue/problem is weirdest issue i had...

Doing game template with C99 for Visual Studio 2019, I added physac.h with being standalone via defining PHYSAC_STANDALONE, But when building solution i get type conflict errors

Screenshot (369)

The problem with both functions GetCurrentTime and GetTimeCount, Anyway...
When i went to their definition, I found that both names used by Windows API functions via WinBase.h, As you see in the image below

Screenshot (370)

So yes, Windows API functions use these names, To solve this i renamed GetCurrentTime to CurrentTime and renamed GetTimeCount to TimeCount everywhere in physac.h

Do you have idea to solve this by checking for Windows platform or Windows API, Tell me...

@ghost
Copy link
Author

ghost commented May 24, 2021

@victorfisac This issue is long time ago, Sorry for ping but really need ya to take look at this...

@ghost
Copy link
Author

ghost commented Jun 12, 2021

Fixed it on my own fork, Closing the issue...

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants