Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Feedback!! #7

Open
codepathreview opened this issue Nov 8, 2016 · 0 comments
Open

Project Feedback!! #7

codepathreview opened this issue Nov 8, 2016 · 0 comments

Comments

@codepathreview
Copy link

codepathreview commented Nov 8, 2016

馃憤 nice work. A few notes after checking out the code:

  • Decent effort on UI polish
  • Glad to see you properly hooked up each of the different timelines to infinitely paginate.
  • Correctly communicated between Fragment and Activity for User Profile
  • Nice to see you used the ViewPager to properly setup the tabs!
  • Nice to see you played around with styling the sliding tab strip
  • Correctly and appropriately used OnClickListeners on the user's profile image to navigate to their profile view
  • Nicely done architecting the fragments (base class and extension classes) such that you put as much code and logic as possible in the base class and then used abstract methods to define only the specific behavior where they differ.

Here's a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

This week (Week 5), we are going to cover the last major piece to the Android puzzle and that is using the hardware and SDK components such as the camera, photo gallery, location, maps, etc. After that, Week 6 and week 7 we will be covering a few important intermediate topics such as more about styling and animation as well as testing.

Following the bootcamp, we are going to have a public demo day to celebrate the progress you've all made with our next batch of Android students and multiple companies attending to see the group projects that you all have built. We are going to help however we can over the next few weeks to get the team project apps in shape for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant