New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing assets #136
Fix missing assets #136
Conversation
Checking branch via Netlify preview, reverting the CORS changes as suggested in #135 did not seem to make a difference. |
@victoriadotdev Netlify deploy previews do not clear the cache: https://stackoverflow.com/questions/50816796/how-to-create-a-netlify-deploy-preview-with-cache-clear I suggest that you test in a browser’s private tab. If the CORS error remain in the private tab, then I suppose that the only way to test if this is fixed is by making an actual commit. |
I'm pretty sure the failing netlify deploy comes from incorrect SiteURL. Currently it is set to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would opt to keep this PR focused on fixing the assets bug and move all other changes to a separate PR.
Okay. Sorry about the reset but this should be much better now. |
@victoriadotdev Please take a look at my comment above
|
ffca8cd
to
31520b6
Compare
This reverts commit 9b49548.