Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing assets #136

Merged
merged 0 commits into from Mar 18, 2019
Merged

Fix missing assets #136

merged 0 commits into from Mar 18, 2019

Conversation

victoriadrake
Copy link
Owner

This reverts commit 9b49548.

@victoriadrake victoriadrake changed the title Revert "CORS and Polish lang (#126)" [WIP] Fix missing assets Mar 14, 2019
@victoriadrake
Copy link
Owner Author

Checking branch via Netlify preview, reverting the CORS changes as suggested in #135 did not seem to make a difference.

@onedrawingperday
Copy link

onedrawingperday commented Mar 14, 2019

@victoriadotdev

Netlify deploy previews do not clear the cache:

https://stackoverflow.com/questions/50816796/how-to-create-a-netlify-deploy-preview-with-cache-clear

I suggest that you test in a browser’s private tab. If the CORS error remain in the private tab, then I suppose that the only way to test if this is fixed is by making an actual commit.

@hanzei hanzei self-requested a review March 14, 2019 09:42
@hanzei
Copy link
Collaborator

hanzei commented Mar 15, 2019

I'm pretty sure the failing netlify deploy comes from incorrect SiteURL. Currently it is set to https://victoria.dev/hugo-theme-introduction. A netlify.toml might fix this.

Copy link
Collaborator

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would opt to keep this PR focused on fixing the assets bug and move all other changes to a separate PR.

.gitignore Outdated Show resolved Hide resolved
LICENSE Outdated Show resolved Hide resolved
i18n/pl.toml Outdated Show resolved Hide resolved
@victoriadrake
Copy link
Owner Author

Okay. Sorry about the reset but this should be much better now.

@hanzei
Copy link
Collaborator

hanzei commented Mar 15, 2019

@victoriadotdev Please take a look at my comment above

I'm pretty sure the failing netlify deploy comes from incorrect SiteURL. Currently it is set to https://victoria.dev/hugo-theme-introduction. A netlify.toml might fix this.

@victoriadrake victoriadrake force-pushed the fix-cors branch 4 times, most recently from ffca8cd to 31520b6 Compare March 18, 2019 18:46
@victoriadrake victoriadrake merged commit f89d9c5 into master Mar 18, 2019
victoriadrake added a commit that referenced this pull request Mar 18, 2019
@victoriadrake victoriadrake deleted the fix-cors branch July 21, 2019 23:54
@hanzei hanzei changed the title [WIP] Fix missing assets Fix missing assets Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants